Housekeeping updates #31
Conversation
Since meeting topics can be added on wendsday, lets move the creation of the issue to right before the meeting, while leaving enough time to ensure the issue is valid/created.
prestist
force-pushed
the
update-schedule
branch
from
e6b3da7 to
ca8e9a8
Compare
prestist
force-pushed
the
update-schedule
branch
7 times, most recently
from
3f6b3a3 to
eab3ebf
Compare
prestist
force-pushed
the
update-schedule
branch
from
eab3ebf to
41205f1
Compare
There was a problem hiding this comment.
@dustymabe When you get the chance could I get a review on this ?
| @@ -20,7 +20,7 @@ export async function run(): Promise<void> { | |||
|
|
|||
| const issueBody = hydrateIssueTemplate(actionItems, meetingTopics) | |||
| console.log('Create issue') | |||
| createThisReposIssue('Fedora CoreOS Weekly Meeting', issueBody) | |||
| createThisReposIssue(issueBody) | |||
There was a problem hiding this comment.
are we somehow losing Fedora CoreOS Weekly Meeting in the issue title?
There was a problem hiding this comment.
Kinda; so this was an artifact of me not understanding actions well. I was passing a lot of values through via the go function signatures; but eventually I learned that you could run it via a config file. and so the "createissue" func was in a mixed state of using signatures and accepting the config file.
I can change it back to "Fedora CoreOS Weekly Meeting" but in this process I also did change the title to 'FCOS Meeting Checklist' ; thought is might be more appropriate?
There was a problem hiding this comment.
I also did change the title to 'FCOS Meeting Checklist' ; thought is might be more appropriate?
+1 - works for me. You should be good to merge this.
No description provided.